-
Notifications
You must be signed in to change notification settings - Fork 3.6k
WIP: add image mask support to media edits #12327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ramonjd
wants to merge
12
commits into
WordPress:trunk
Choose a base branch
from
ramonjd:backport/wp-attachment-image-masking
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7ce00ee
Add image mask support to media edits
ramonjd 74f0557
Fix image mask PHPCS formatting
ramonjd 8107827
Use optional image editor mask method
ramonjd 4d2b3ef
Clarify explicit image editor output type
ramonjd 6267cc3
Address image mask review feedback
ramonjd b1f748f
Media: negotiate alpha-capable output format for masked image edits
ramonjd d57c6e0
Tests: avoid leaving a temp file behind in image mask tests
ramonjd d13c725
Media: harden mask output-format suppression priority
ramonjd 6c34f40
REST API: Regenerate client fixtures for the mask edit modifier
ramonjd 15f7b3f
Docs: target 7.2.0 for image mask support and annotate affected methods
ramonjd 9266c0e
Apply suggestion from @ramonjd
ramonjd 8c4ddd7
Docs: match the GD mask comment to the $span variable name
ramonjd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.