Code Editor: Distinguish the active persistent search result - #12769
Code Editor: Distinguish the active persistent search result#12769Sukhendu2002 wants to merge 3 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR improves the WP admin CodeMirror-based code editor search UI by adding a distinct visual treatment for the active “persistent search” match while the search input is focused, and adds E2E coverage to prevent regressions.
Changes:
- Add a JS behavior to mark the currently active search result with a dedicated CSS class while the search field is focused.
- Add admin CSS styling for the active persistent search result marker when the editor is not focused.
- Add Playwright E2E tests covering the active marker behavior and interactions with
styleSelectedTextdefaults/overrides.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/e2e/specs/code-editor-search.test.js |
Adds E2E specs asserting active vs inactive persistent search result behavior and styleSelectedText interactions. |
src/wp-admin/css/code-editor.css |
Styles .CodeMirror-searching-selected to visually distinguish the active match when editor focus is elsewhere (e.g., search field). |
src/js/_enqueues/wp/code-editor.js |
Adds configurePersistentSearchHighlight() to mark the active match while the search field has focus, and wires it into editor initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/42586
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.