Skip to content

Code Editor: Distinguish the active persistent search result - #12769

Open
Sukhendu2002 wants to merge 3 commits into
WordPress:trunkfrom
Sukhendu2002:fix/42586-highlight-active-search-result
Open

Code Editor: Distinguish the active persistent search result#12769
Sukhendu2002 wants to merge 3 commits into
WordPress:trunkfrom
Sukhendu2002:fix/42586-highlight-active-search-result

Conversation

@Sukhendu2002

@Sukhendu2002 Sukhendu2002 commented Jul 30, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/42586

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 30, 2026 12:35
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the WP admin CodeMirror-based code editor search UI by adding a distinct visual treatment for the active “persistent search” match while the search input is focused, and adds E2E coverage to prevent regressions.

Changes:

  • Add a JS behavior to mark the currently active search result with a dedicated CSS class while the search field is focused.
  • Add admin CSS styling for the active persistent search result marker when the editor is not focused.
  • Add Playwright E2E tests covering the active marker behavior and interactions with styleSelectedText defaults/overrides.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/e2e/specs/code-editor-search.test.js Adds E2E specs asserting active vs inactive persistent search result behavior and styleSelectedText interactions.
src/wp-admin/css/code-editor.css Styles .CodeMirror-searching-selected to visually distinguish the active match when editor focus is elsewhere (e.g., search field).
src/js/_enqueues/wp/code-editor.js Adds configurePersistentSearchHighlight() to mark the active match while the search field has focus, and wires it into editor initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/js/_enqueues/wp/code-editor.js Outdated
Copilot AI review requested due to automatic review settings July 30, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@Sukhendu2002
Sukhendu2002 marked this pull request as ready for review July 30, 2026 12:58
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants