Rewrite: extra_rules_top takes priority over extra_permastructs on regex conflicts - #12774
Rewrite: extra_rules_top takes priority over extra_permastructs on regex conflicts#12774SainathPoojary wants to merge 3 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates how WP_Rewrite::rewrite_rules() composes the final rewrite rules array so that rules in extra_rules_top take precedence over rules generated from extra_permastructs when they share the same regex key (per Trac #14991).
Changes:
- Collect extra permastruct-generated rules into a separate
$permastruct_rewritearray instead of merging them directly intoextra_rules_top. - Switch the final rewrite-rule composition to use PHP array union (
+) to prefer earlier keys on conflicts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Put them together. | ||
| if ( $this->use_verbose_page_rules ) { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $page_rewrite, $post_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $page_rewrite + $post_rewrite + $this->extra_rules; | ||
| } else { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $post_rewrite, $page_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $post_rewrite + $page_rewrite + $this->extra_rules; |
| // Put them together. | ||
| if ( $this->use_verbose_page_rules ) { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $page_rewrite, $post_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $page_rewrite + $post_rewrite + $this->extra_rules; |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: #14991
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.