Skip to content

Build/Test Tools: Format copied Gutenberg style registry - #12778

Open
benitoalba wants to merge 2 commits into
WordPress:trunkfrom
benitoalba:fix/65278-generated-php-formatting
Open

Build/Test Tools: Format copied Gutenberg style registry#12778
benitoalba wants to merge 2 commits into
WordPress:trunkfrom
benitoalba:fix/65278-generated-php-formatting

Conversation

@benitoalba

Copy link
Copy Markdown

Formats the generated Gutenberg style registry while it is copied into Core.

Gutenberg currently outputs registry.php with unaligned array operators and missing spaces inside non-empty dependency arrays. Running build:dev followed by a Core PHPCS scan therefore reports coding standards violations. The copy step now normalizes those known fields without requiring PHP or Composer in build-only jobs.

Trac ticket: https://core.trac.wordpress.org/ticket/65278

Testing

  • npm run build:dev
  • npm run grunt jshint:grunt
  • php -l src/wp-includes/css/dist/registry.php
  • php ./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/css/dist/registry.php
  • php ./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=phpcompat.xml.dist src/wp-includes/css/dist/registry.php
  • git diff --check

Before the change, PHPCS reported 34 errors and 38 warnings in the generated registry. After the change, both PHPCS rulesets pass.

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Issue research, implementation, and local validation.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 30, 2026 21:26
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Core build pipeline to normalize formatting in the copied Gutenberg style registry (registry.php) so that Core PHPCS scans pass in build-only environments without requiring PHP/Composer tooling.

Changes:

  • Adds a copy:gutenberg-styles options.process hook that only targets registry.php.
  • Normalizes alignment around => for the handle, path, and dependencies keys, and adjusts spacing in non-empty dependency arrays during the copy step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Gruntfile.js
@benitoalba
benitoalba marked this pull request as ready for review July 30, 2026 23:37
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props benitoalba.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants