Build/Test Tools: Format copied Gutenberg style registry - #12778
Build/Test Tools: Format copied Gutenberg style registry#12778benitoalba wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
Updates the Core build pipeline to normalize formatting in the copied Gutenberg style registry (registry.php) so that Core PHPCS scans pass in build-only environments without requiring PHP/Composer tooling.
Changes:
- Adds a
copy:gutenberg-stylesoptions.processhook that only targetsregistry.php. - Normalizes alignment around
=>for thehandle,path, anddependencieskeys, and adjusts spacing in non-empty dependency arrays during the copy step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Formats the generated Gutenberg style registry while it is copied into Core.
Gutenberg currently outputs
registry.phpwith unaligned array operators and missing spaces inside non-empty dependency arrays. Runningbuild:devfollowed by a Core PHPCS scan therefore reports coding standards violations. The copy step now normalizes those known fields without requiring PHP or Composer in build-only jobs.Trac ticket: https://core.trac.wordpress.org/ticket/65278
Testing
npm run build:devnpm run grunt jshint:gruntphp -l src/wp-includes/css/dist/registry.phpphp ./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/css/dist/registry.phpphp ./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=phpcompat.xml.dist src/wp-includes/css/dist/registry.phpgit diff --checkBefore the change, PHPCS reported 34 errors and 38 warnings in the generated registry. After the change, both PHPCS rulesets pass.
Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Issue research, implementation, and local validation.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.