Skip to content

Editor: Don't move focus to the editor when switching editor mode - #12786

Open
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/editor-mode-switch-focus
Open

Editor: Don't move focus to the editor when switching editor mode#12786
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/editor-mode-switch-focus

Conversation

@shrivastavanolo

Copy link
Copy Markdown

Previously, switching between Visual and Text mode would unconditionally move focus into the destination editor (via editor.focus() / textArea.focus()), because the selection-bookmark mechanism used to preserve cursor position across the switch is populated almost every time, regardless of whether the source field was actually focused.

In the common case — clicking the Visual/Text tab — focus has already moved to that tab button by the time the switch handler runs, so forcibly focusing the editor content area pulls focus away from the control the user just activated. This is disruptive for keyboard and assistive technology users, who lose their place in the document unexpectedly.

Now, focus is only moved into the destination editor if the source field already had focus when the switch was triggered (e.g. a keyboard shortcut fired while actively editing). The cursor/selection position is still restored either way, so it's correct if the user does click into the field afterward — only the automatic focus-stealing (and the accompanying scroll-into-view, which would otherwise move the page without moving focus) is skipped.

Trac ticket: https://core.trac.wordpress.org/ticket/42540

Use of AI Tools

AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.7
Used for: Initial code skeleton; final implementation was reviewed and tested by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreya0shrivastava.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant