Users: Preserve early-authenticated user ID in determine_current_user filter chain - #12789
Draft
himanshupathak95 wants to merge 5 commits into
Draft
Users: Preserve early-authenticated user ID in determine_current_user filter chain#12789himanshupathak95 wants to merge 5 commits into
determine_current_user filter chain#12789himanshupathak95 wants to merge 5 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/28212
When a callback registered on the determine_current_user filter at a priority lower than 10 authenticates a user and returns a user ID, wp_validate_auth_cookie (hooked directly at priority 10) receives that user ID as its $cookie argument.
Because wp_validate_auth_cookie expected a cookie string, it failed parsing and returned false, overriding the user ID determined by the earlier filter callback.
Since we cannot wrap wp_validate_auth_cookie in a new filter callback function (like wp_validate_logged_in_cookie) because changing the hook name in default-filters.php would break backward compatibility for countless stateless API plugins that rely on remove_filter( 'determine_current_user', 'wp_validate_auth_cookie' ).
Instead, this PR adds a safeguard inside wp_validate_auth_cookie() in pluggable.php. If a user ID (non-string or numeric value) is passed, it returns it immediately. If no user ID is passed, it falls through to wp_parse_auth_cookie(), preserving the existing is_ssl() auto-detection logic perfectly.