Privacy: Rename "Complete request" to "Close request" on the Erase Personal Data screen - #12793
Conversation
…rsonal Data screen The row action "Complete request" in the Erase Personal Data list table was easily mistaken for an instruction to execute the erasure, when in fact it only marks the request as completed without running any erasers. Rename it to "Close request" to make clear the action does not erase data, following the suggestion from the ticket. Also fix an incorrect aria-label that said "Mark export request for..." on the erasure screen — it now correctly says "Mark erasure request for..." Fixes #65735.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
The row action "Complete request" on Tools → Erase Personal Data is easily mistaken for an instruction to execute the erasure. In reality it only marks the request as completed (for manually-fulfilled requests) and runs no erasers. A site owner clicking it expecting data to be erased will see a Completed status with data still intact.
Two bugs fixed:
Complete request→Close request(per the suggestion in the ticket), making it clear the action does not erase data.The bulk action in
WP_Privacy_Requests_Table::get_bulk_actions()already uses the labelMark requests as completed, so this row action was the only inconsistency.Testing
Added
tests/phpunit/tests/privacy/wpPrivacyDataRemovalRequestsListTable.phpwith two assertions:Close requestand notComplete requesterasure requestand notexport requestFixes https://core.trac.wordpress.org/ticket/65735