Skip to content

Privacy: Rename "Complete request" to "Close request" on the Erase Personal Data screen - #12793

Open
HasnainAshfaq wants to merge 1 commit into
WordPress:trunkfrom
HasnainAshfaq:feature/65735-privacy-close-request-label
Open

Privacy: Rename "Complete request" to "Close request" on the Erase Personal Data screen#12793
HasnainAshfaq wants to merge 1 commit into
WordPress:trunkfrom
HasnainAshfaq:feature/65735-privacy-close-request-label

Conversation

@HasnainAshfaq

Copy link
Copy Markdown

Summary

The row action "Complete request" on Tools → Erase Personal Data is easily mistaken for an instruction to execute the erasure. In reality it only marks the request as completed (for manually-fulfilled requests) and runs no erasers. A site owner clicking it expecting data to be erased will see a Completed status with data still intact.

Two bugs fixed:

  • Misleading label: Renamed Complete requestClose request (per the suggestion in the ticket), making it clear the action does not erase data.
  • Wrong aria-label: The accessible label read "Mark export request for…" on the erasure screen — a copy-paste error from the export list table. Fixed to "Mark erasure request for…"

The bulk action in WP_Privacy_Requests_Table::get_bulk_actions() already uses the label Mark requests as completed, so this row action was the only inconsistency.

Testing

Added tests/phpunit/tests/privacy/wpPrivacyDataRemovalRequestsListTable.php with two assertions:

  • Row action output contains Close request and not Complete request
  • Aria-label contains erasure request and not export request

Fixes https://core.trac.wordpress.org/ticket/65735

…rsonal Data screen

The row action "Complete request" in the Erase Personal Data list table
was easily mistaken for an instruction to execute the erasure, when in
fact it only marks the request as completed without running any erasers.

Rename it to "Close request" to make clear the action does not erase
data, following the suggestion from the ticket.

Also fix an incorrect aria-label that said "Mark export request for..."
on the erasure screen — it now correctly says "Mark erasure request for..."

Fixes #65735.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hasnainashfaq.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant