fix(base-io): stop excessive re-reads in LookaheadReader's single-char lookahead path - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LookaheadReader.prepare()(the no-arg overload used byconsume(),peek(),available(), andfollows()) delegated toprepare(DEFAULT_LOOKAHEAD), requesting a full 4096-character lookahead even for single-character operations.Because the internal buffer is sized to exactly
DEFAULT_LOOKAHEADby default, this made the "not enough room" shuffle condition (index + desired > buffer.length) true again immediately after consuming just one character, forcing a fresh underlyingread()call on essentially every singleconsume(). The fix changes the no-argprepare()to request adesiredof1instead, so the refill only triggers when the buffer is actually empty; the top-up read still fills as much of the buffer as is available, so bulk consumption viaconsume(int)is unaffected.