Skip to content

chore: remove java.sql dependency from base-foundation and base-transport-json #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deer merged 1 commit into from
Jun 17, 2026
Merged

chore: remove java.sql dependency from base-foundation and base-transport-json #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base-foundation/src/main/java/build/base/foundation/Strings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ private Strings() {
registerParser(map, AtomicLong.class, s -> new AtomicLong(convert(s, long.class)));
registerParser(map, AtomicBoolean.class, s -> new AtomicBoolean(convert(s, boolean.class)));
registerParser(map, Date.class, s -> new Date(Instant.parse(s).toEpochMilli()));
registerParser(map, java.sql.Date.class, s -> new java.sql.Date(Instant.parse(s).toEpochMilli()));
registerParser(map, Duration.class, s -> s.contains("P") ? Duration.parse(s) : parsePrettyDuration(s));
registerParser(map, Instant.class, Instant::parse);
registerParser(map, LocalDate.class, LocalDate::parse);
Expand Down
2 changes: 0 additions & 2 deletions base-foundation/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
* @since Feb-2024
*/
module build.base.foundation {
requires java.sql;

exports build.base.foundation;
exports build.base.foundation.iterator;
exports build.base.foundation.iterator.matching;
Expand Down
2 changes: 0 additions & 2 deletions base-telemetry-ansi/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
* @since May-2025
*/
module build.base.telemetry.ansi {
requires java.compiler;

requires build.base.foundation;
requires transitive build.base.telemetry;
requires transitive build.base.telemetry.foundation;
Expand Down
2 changes: 0 additions & 2 deletions base-transport-json/src/main/java/build/base/transport/json/JsonTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import build.base.transport.json.codec.PeriodCodec;
import build.base.transport.json.codec.StreamableCodec;
import build.base.transport.json.codec.StringCodec;
import build.base.transport.json.codec.TimestampCodec;
import build.base.transport.json.codec.ZonedDateTimeCodec;

import java.io.IOException;
Expand Down Expand Up @@ -121,7 +120,6 @@ public JsonTransport(final SchemaFactory schemaFactory) {
register(new DurationCodec());
register(new PeriodCodec());
register(new DateCodec());
register(new TimestampCodec());
}

/**
Expand Down
61 changes: 0 additions & 61 deletions base-transport-json/src/main/java/build/base/transport/json/codec/TimestampCodec.java
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions base-transport-json/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,5 @@
requires build.base.marshalling;
requires build.base.transport;

requires java.sql;

exports build.base.transport.json;
}
31 changes: 15 additions & 16 deletions base-transport-json/src/test/java/build/base/transport/json/example/Uber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import java.lang.invoke.MethodHandles;
import java.math.BigDecimal;
import java.math.BigInteger;
import java.sql.Timestamp;
import java.time.Duration;
import java.time.Instant;
import java.time.LocalDate;
Expand Down Expand Up @@ -110,8 +109,8 @@ public class Uber {
private final Date aDate;
private final Date aNullDate;

private final Timestamp aTimestamp;
private final Timestamp aNullTimestamp;
private final Instant anotherInstant;
private final Instant aNullAnotherInstant;

public Uber() {
this.anInteger = 1;
Expand Down Expand Up @@ -175,8 +174,8 @@ public Uber() {
this.aDate = new Date(2024, Calendar.NOVEMBER, 1);
this.aNullDate = null;

this.aTimestamp = new Timestamp(2024, Calendar.NOVEMBER, 1, 14, 31, 7, 0);
this.aNullTimestamp = null;
this.anotherInstant = Instant.ofEpochSecond(2000);
this.aNullAnotherInstant = null;
}

@Unmarshal
Expand Down Expand Up @@ -223,8 +222,8 @@ public Uber(final int anInteger,
final Period aNullPeriod,
final Date aDate,
final Date aNullDate,
final Timestamp aTimestamp,
final Timestamp aNullTimestamp) {
final Instant anotherInstant,
final Instant aNullAnotherInstant) {

this.anInteger = anInteger;
this.anIntegerWrapper = anIntegerWrapper;
Expand Down Expand Up @@ -287,8 +286,8 @@ public Uber(final int anInteger,
this.aDate = aDate;
this.aNullDate = aNullDate;

this.aTimestamp = aTimestamp;
this.aNullTimestamp = aNullTimestamp;
this.anotherInstant = anotherInstant;
this.aNullAnotherInstant = aNullAnotherInstant;
}

@Marshal
Expand Down Expand Up @@ -335,8 +334,8 @@ public void destructor(final Out<Integer> anInteger,
final Out<Period> aNullPeriod,
final Out<Date> aDate,
final Out<Date> aNullDate,
final Out<Timestamp> aTimestamp,
final Out<Timestamp> aNullTimestamp) {
final Out<Instant> anotherInstant,
final Out<Instant> aNullAnotherInstant) {

anInteger.set(this.anInteger);
anIntegerWrapper.set(this.anIntegerWrapper);
Expand Down Expand Up @@ -399,8 +398,8 @@ public void destructor(final Out<Integer> anInteger,
aDate.set(this.aDate);
aNullDate.set(this.aNullDate);

aTimestamp.set(this.aTimestamp);
aNullTimestamp.set(this.aNullTimestamp);
anotherInstant.set(this.anotherInstant);
aNullAnotherInstant.set(this.aNullAnotherInstant);
}

@Override
Expand Down Expand Up @@ -434,8 +433,8 @@ public boolean equals(final Object o) {
&& Objects.equals(aNullZonedDateTime, uber.aNullZonedDateTime) && aDuration.equals(uber.aDuration)
&& Objects.equals(aNullDuration, uber.aNullDuration) && aPeriod.equals(uber.aPeriod) &&
Objects.equals(aNullPeriod, uber.aNullPeriod) && aDate.equals(uber.aDate) && Objects.equals(aNullDate,
uber.aNullDate) && aTimestamp.equals(uber.aTimestamp) && Objects.equals(aNullTimestamp,
uber.aNullTimestamp);
uber.aNullDate) && anotherInstant.equals(uber.anotherInstant) && Objects.equals(aNullAnotherInstant,
uber.aNullAnotherInstant);
}

@Override
Expand All @@ -447,7 +446,7 @@ public int hashCode() {
aDoubleWrapper, aNullDoubleWrapper, aBigDecimal, aNullBigDecimal, aBigInteger, aNullBigInteger, anInstant,
aNullInstant, aLocalDate, aNullLocalDate, aLocalTime, aNullLocalTime, aLocalDateTime, aNullLocalDateTime,
aZonedDateTime, aNullZonedDateTime, aDuration, aNullDuration, aPeriod, aNullPeriod, aDate, aNullDate,
aTimestamp, aNullTimestamp);
anotherInstant, aNullAnotherInstant);
}

static {
Expand Down