feat(base-foundation): add Memoizer.computeWith for ad-hoc per-call suppliers - #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memoizerpreviously only supported memoizing a single fixedFunction<T, R>supplied at construction time viaMemoizer.of(fn), so callers who wanted to share one cache across call sites with different computations for the same key type had no way to do so.This adds
computeWith(T input, Supplier<R> supplier)to theMemoizerinterface, which checks the cache forinputexactly likecomputebut falls back to invokingsupplieron a miss instead of the memoizer's fixed function. On a cache hit the supplier is never invoked, and if two callers race on the same key with different suppliers only one result is memoized.computeitself is now implemented in terms ofcomputeWith, so the two abstract bases (AbstractMemoizerandAbstractConcurrentMemoizer, including the latter's per-keyReentrantLockre-entrancy handling) each keep a single code path rather than two, and all six concrete implementations (StrongMemoizer,SoftMemoizer,WeakMemoizer, and their concurrent counterparts) get the new method for free.