Fix docker build#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Docker workflow to reliably build the .NET image on PRs while only authenticating and pushing to Docker Hub on branch pushes.
Changes:
- Consolidates build/push logic into a single
build-and-pushjob with conditional Docker Hub login andpush. - Updates GitHub Actions and Docker actions to newer major versions (checkout, buildx/qemu, login, build-push).
- Replaces custom tag scripting with
docker/metadata-actionfor consistent tags/labels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build GitHub Actions workflow to modernize dependencies, streamline the build and push process, and improve maintainability. The workflow now uses newer versions of actions, consolidates build and push steps, and introduces dynamic Docker image tagging.
Workflow modernization and simplification:
actions/checkout@v4,docker/setup-qemu-action@v3,docker/setup-buildx-action@v3,docker/build-push-action@v6, etc.) and consolidated the build and push steps into a singlebuild-and-pushjob for clarity and maintainability.docker/metadata-action@v5, enabling dynamic tagging based on branch, commit SHA, and themasterbranch.Secrets and authentication improvements:
v4and improved secret loading logic, ensuring Docker Hub credentials are only loaded and used onpushevents.docker/login-action@v3and made the login conditional onpushevents for better security and efficiency.Build process enhancements: