Fix comparison logic for ECDSA public keys#290
Merged
kislyuk merged 1 commit intoFeb 18, 2026
Conversation
MatthiasValvekens
force-pushed
the
bugfix/ec-public-key-compare
branch
from
5606eb8 to
e59bdec
Compare
MatthiasValvekens
added a commit
to MatthiasValvekens/pyHanko
that referenced
this pull request
Feb 18, 2026
Generate test TLs without KeyValue to work around a validation bug introduced in v4.3.0 (see XML-Security/signxml#290).
Member
|
Thanks for finding and fixing this! |
Member
|
Released in v4.3.1. |
JanSoderback
pushed a commit
to JanSoderback/signxml
that referenced
this pull request
Feb 18, 2026
The key comparison logic for ECDSA keys contains an error in the curve type comparison, causing it to report a mismatch even if the keys are the same. This PR fixes said error, and adds tests exercising the ECDSA branch of this logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key comparison logic for ECDSA keys contains an error in the curve type comparison, causing it to report a mismatch even if the keys are the same. This PR fixes said error, and adds tests exercising the ECDSA branch of this logic.