Skip to content

fix(devnet): update chain ID and genesis parameters for Devnet #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anunay-xin wants to merge 2 commits into
base: dev-upgrade
Choose a base branch
from
Open

fix(devnet): update chain ID and genesis parameters for Devnet #2307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb10ef1
fix(devnet): update chain ID and genesis parameters for Devnet config…
anunay-xin Apr 15, 2026
bd4cd58
params: update block parameters for pragueBlock, tipUpgradeReward, an…
anunay-xin Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/utils/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,7 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
cfg.Genesis = core.DefaultTestnetGenesisBlock()
case ctx.Bool(DevnetFlag.Name):
if !ctx.IsSet(NetworkIdFlag.Name) {
cfg.NetworkId = 551
cfg.NetworkId = 5551
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description repeatedly says 'chain ID' is updated, but this change updates cfg.NetworkId (the devp2p network ID), not the EIP-155 chain ID (which typically lives in the chain config/genesis). It would help to either adjust the PR description to say 'network ID' here, or (if chain ID updates are also intended) ensure they’re clearly called out where ChainID is actually changed.

Copilot uses AI. Check for mistakes.
}
cfg.Genesis = core.DefaultDevnetGenesisBlock()
case ctx.Bool(DeveloperFlag.Name):
Expand Down Expand Up @@ -1681,7 +1681,7 @@ func SetNetworkFlagById(ctx *cli.Context, cfg *ethconfig.Config) {
case 51:
common.IsTestnet = true
ctx.Set(TestnetFlag.Name, "true")
case 551:
case 5551:
ctx.Set(DevnetFlag.Name, "true")
}
}
Expand Down
4 changes: 2 additions & 2 deletions common/constants.devnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ var DevnetConstant = constant{
mergeBlock: big.NewInt(0),
shanghaiBlock: big.NewInt(0),
blockNumberGas50x: big.NewInt(0),
TIPV2SwitchBlock: big.NewInt(0),
TIPV2SwitchBlock: big.NewInt(2700),
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple independent upgrade toggles are now hard-coded to the same magic height (5,000,000). Without an inline comment clarifying why these upgrades must coincide on Devnet (and what each toggle controls), this becomes easy to mis-edit later and can lead to accidental partial upgrades. Suggest adding brief comments per field (or named constants) documenting the rationale for each activation height, especially since dynamicGasLimitBlock, tipUpgradeReward, and tipUpgradePenalty are conceptually different switches.

Copilot uses AI. Check for mistakes.
tipXDCXMinerDisable: big.NewInt(0),
tipXDCXReceiverDisable: big.NewInt(0),
eip1559Block: big.NewInt(250000),
cancunBlock: big.NewInt(250000),
pragueBlock: big.NewInt(math.MaxInt64),
osakaBlock: big.NewInt(math.MaxInt64),
dynamicGasLimitBlock: big.NewInt(math.MaxInt64),
dynamicGasLimitBlock: big.NewInt(5000000),
tipUpgradeReward: big.NewInt(math.MaxInt64),
tipUpgradePenalty: big.NewInt(math.MaxInt64),
tipEpochHalving: big.NewInt(math.MaxInt64),
Expand Down
4 changes: 2 additions & 2 deletions core/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,11 +462,11 @@ func DefaultDevnetGenesisBlock() *Genesis {
return &Genesis{
Config: params.DevnetChainConfig,
Nonce: 0,
ExtraData: hexutil.MustDecode("0x0000000000000000000000000000000000000000000000000000000000000000311bdf9066246e68559816e7f636435867f824ef442a44a6fc20f5b8dfa8b304d7137581f7e6bef347318441696e9ae962633c16e04d53935272639d537fc89618edae86950e12687a612e15c4786b8473898cc3c5beca5841306b26fdb4e30411392a6a74826141342a4dc33a1045cefa4182b6212ec0317bc30fbeb7208192d1474b5f87ffbc056de43c11888c073313b36cf03cf1f739f39443551ff12bbe8d993351c0e2db739f9bcbfdeda94d73b50b16d3a242960b7ca1937e826bda6c397df74d9f9ab01aa89af636787499e81362e815e36f28763eac120babebf5a6cbe6113780cbe489e3eb0db882381aebaf81190100d82f41ad2c95898195c7a47dc59115bb5ec85408683795da2f604a5c0464868eabfcb6da489a1b4304f49aafaec938c7adc48539470624e1f9c75ce33e568d8fa3ace90497ee0c60dc921eefea93e384a6ccaaf28e33790a2d1b2625bf964dfc087e2622b02b0bb78713e872c02796ef64c8f10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"),
ExtraData: hexutil.MustDecode("0x0000000000000000000000000000000000000000000000000000000000000000008661dde98c6106224ac8d5e0356d6fdbf3923101346a2d41542d859e03f461ca74a1ff2686884c02729a332e4e16e4f02ff8a416a2006f943e110a066711cbf42f9ead9fca8a27a12f5f11e10f3ed6081f1ab6bfe1e01900e15164a0fe34283d32671c0983ab0acc9c0107031e681d128811f056b4e4150aed5c578e40595111352111472ea1ba55b1aad90fe62f8436d88005e2d69f3caeba10a713cd02a811c8ee9b7383eee8cb7967c60c09f9f5b6aa499d12fe3a241c805a94fecf98e9f2eab7370fb1873715df6e75c7d1cb8af14049caca19ed207cfb98bf180a2d5371a78de6376fdd0b7113d4364976a98e1bfa7d6cc47cf4be7362a288a531d6c621c337602026f1a303c8931793ad4eb38c1f2d45a7076ec62280e7bd75984b8dd8314330fbedbaa48984b45122f69af9d2268dbd79536e12c7af4afb462eaedd258fedd147585f34c5b2897e21ff7f7551340303263f0892e3a8a70c7debc968f66f1f2caca535082686b03018b3b811ac1fb42dbc6b325255e0fad826d5f7bcc51afc06d4284969ab8757f3e689163c2c2884f6c107184a4b9721aa84e7a2e901c81c9e2cc7bd34266d54ccd6d89296f0b8bc99faefc3772d5271b9f4692c1e36a1a862bea311cb6705f5872e3f6d1c0598c2d54c69d4011effc480407230842e67af84716b566b177dcf22d5a1062871d832ec3058a76ce02c06d6ff370882fa96ff42b9aeb6ca32be73ad19e1003eb3ad225d9059522059e36f8932c6cfb950940906a0212ce200092841b7a96dd1334fe0c390ff84448b4be1eb797b22e7ea5162e83a71897dd5f257b8376e37612d41635e63c715543d1daacc23b64751c1114f985912ce2b292ee2753eadc9be2dbc465d3f435adc85c5768e7c973f493fa2e9cab94aa24d536f10c0341edec4b662d0c34968f17a784968f884e2e51057c6fbe992c19d044a76a959b27d1f8c2aaa9d448a92b93be32020204b042ef47e5b12e511d1097eb7cf2e2b21f433304b4cf8b8d730c8f1b90b260f030840e735fe143e4ed19e4e0b08ddc57368ba278be696ac92ed6ab74ed4aa631ef6d9c02ba707782c875d9c44f80a835180f7a3beba24f5f4d70ecaf238aeee127a056d527dbaef13ab0431463d84355b47c4b9e66b5af1565a8d0da480bbc7fee3ad5e17d4e6c5fec0b5b657267ea675c25d669b6529bbbec5cf7e9283a117587a573ddbd2729f60bd4ebc9fb855bcbfb5c9215ad2a5f826c5028d82466dbb9d2a8bb03f1d0a965b5e45373d2c8a7235e4d6c3835fc6a4d00ebd105e6c696185044ce4f35508c04a8c8b3d99857cca61ce0cbd9364ee68e5336286387f2070e6abf69c6356862749cf11ed9b900228937a0172100ddb6563f915e663857b8a9f6a7a0e50cfe148fe310cc565a01d5808f1b0050702c49f150ae55137f90a7d67655cc7b49f4a33330249b82172961275604ef4685008ff89f3b10a85fa57b2accbca976603e7026969067dc17d6a6e5ce5939ab823072961e3b2f06afb44e2268e9ec27e73ebe0c11f79aa83de76fc6b77d1702ae1395c62a4368f7e8af39c02e799c96e851e2a96d094827470d0cf75362028527f3a0b71141ee85dc573b1a8a6eeae8dcc75a8e9d632b0782ffa5fdfb86c95fb891cec0bcd76413a9f38c178cbe4bc26aca957c439e20dc93fb5a9b2def5807974725114d48b6df7a2eb8b9f320addd4a732087e34d797f211ed1343ff9b5a8ff42fa0f3360d018013f4f2ae62c66416e4e0c8e95f0c8f0d1ad2e6830fb3711887f1f3b248c75bacaffe4e5f7fcdb289f5398bc06a32b84df3a2b9168aa6baf44110e88d13512e552e2032662fc8e910992f82a4493863917c67a7670441c22a16f47e85fb217312d6ca7893727b60f3e372bbfd6fdd076cf26e2e739ac737989e2807357ed613456af5d0b0a4c1a95594ba639def92fc6c55f98d09143d067998754237168365a08cc01242805ff9bcff7e46c14f8b454efaf0b1a5824fbc2b2db519039bb6ef9d6ab94110499a88ab8218ace9a7ef792c7527c226edc2183b3644d9abafbb0dce2fe4045ca90c06688201b8d08dafb7acb6efd260247cc56dc5aec68be725279c628f92ace6f5e22342b6d8e2c3f84b4d849bc1462bb173ad579fe5042a3e8d24b32499e80ee2bf5ed151fcae07b743487735e11d3b23bfb92475e90666f10bb0103109820e4907a277bc5492b09f502653308db25d2672ef54675df6a3159502f773c499498655b4210783b2cdf2ea5c878804c1948e94a5b6168cb5805efb3644b56a83569aa233f1a7f61255e247bd268f078c918db93dbce96e3d903dcb0f5f6378be25fe68a64e205de647c9116fc52c53432aba32c0772e0de9829847800de5e88936570c09ce7263c1a9f8f77b0afc5eadc2dc78106879eb3126bc62c205f666038daba72abcd4d23d77e9c774fdebaac34a3cd97fb1bb894f525d1a1f3ea18c592a3b08c3cb578638427389b7c6402d0b1a8de3e89a9b7bc6379a39caf697b91b3e4ea9a227bb940f70d96dc74d1b890db7eddb783b2f7e5dd3f010739df8e1c7c93c8aeaffea97e868168b8c3d754463e6d737c825253cad4cbf989201d7bd369fef887309c1b2cb1269432a080dbcff8053d7759e0c4962bec94dcdff7f7ec050b7a413626289a35616c0bc67a1e9ce49f6ea69bb0237303f90cbeb28a9665415b7cfcfb43f059e39456b29facabded44684cac35b04fd02310501c429f631b3097a4a0da84054a46cfecd483d3c52ebf10d94bca3c97ecfcfca88db84123d881cd6291e5463cbf200f90b9027c303cd84ba1d9b1d9d839d2218a5d313f27344cb7d8a3f1d95ddb83be484441c73848667000e5ce4001aec09d9bdde8431deb1004fbc35c579fd4f51b4c89f571e6de080a32c22019427b55e0326245a4bbe98544bfdf5d49f8477df0a9dbc7e0c6b2dc87e65b87b88ee07ba33902c8678108bd1fb2c79eb5863971f9f3e0cf647a85205c87d1352e19b28c37cfc6de8c33e1c427f8bf873e0bf5195bf78fd7b38ba0c4ced8e3c3c3febd671dc0e0ad3371366d968de46c4024e53e0f04360b4313173a5f266866fd248f94fec0e71ac88ffaf8d4c7b4d63f56a8859fa6f9f8ab85e901cc3175a3749c2d27c6bc051ca7c978626c43e9315c6c526c6acb478c0921fd28bbaa0a64b4c3ea5be13349f0bef623a40a74c3dda20c2c574a5eeabe066c8a4ac6fa52d70e0048ee5cadaa950736ed9221649af1eddbb6210fbc9ed713a757d6b096ee083522d9aad8938dfa7c260c10c9a29d7805b4f0c3bff6dd2e5ef97242ffc54d38be859c3a71b5f843965289b35dc11ce2873636b467bb3fafb699fa80871e330ca3ddb306bd5e6adb972f3303d96cfc1c194f8716d41709fbfe3acfb634c4b25939ddfe3424efa8ed03eae9a2bf4d001692abc1807a6cfe56bae25b109e61e5026b5e4e62c865fc6470f9ff7bb7db2ceb6cc08f718bcba954915bf1774df1fff2331a010cba90682763172b19f57f27831ac70000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"),
GasLimit: 4700000,
Difficulty: big.NewInt(1),
Alloc: DecodeAllocJson(DevnetAllocData),
Timestamp: 1735513074,
Timestamp: 1765137783,
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raw Unix timestamp is hard to review/verify later. Consider adding a short comment with the human-readable UTC date/time (or generating it via a clearly documented constant) so reviewers/operators can quickly validate the intended genesis time.

Copilot uses AI. Check for mistakes.
}
}

Expand Down
2 changes: 1 addition & 1 deletion core/genesis_alloc_devnet.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading