Skip to content

Attempt at fixing pipeline issue#352

Merged
mikoarce merged 2 commits into
masterfrom
fix-pipeline-ubuntu-bump
May 6, 2025
Merged

Attempt at fixing pipeline issue#352
mikoarce merged 2 commits into
masterfrom
fix-pipeline-ubuntu-bump

Conversation

@mikoarce
Copy link
Copy Markdown
Contributor

@mikoarce mikoarce commented May 6, 2025

See sample action: https://github.com/Yelp/dataloader-codegen/actions/runs/14862750312

We're getting: This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101

@mikoarce mikoarce requested a review from Copilot May 6, 2025 15:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the workflows to resolve pipeline issues related to the deprecation of Ubuntu 20.04 runners and makes minor style improvements in the tests.

  • Updated workflow configurations in test.yml and release.yml to use Ubuntu 22.04.
  • Adjusted arrow function syntax in tests/implementation.test.js for consistency.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/implementation.test.js Updated arrow function syntax and trailing commas for consistent style.
.github/workflows/test.yml Changed runner from ubuntu-20.04 to ubuntu-22.04 to address pipeline deprecation issue.
.github/workflows/release.yml Updated runner configuration similarly to test.yml.

@mikoarce mikoarce marked this pull request as ready for review May 6, 2025 15:13
@mikoarce mikoarce requested a review from silversoup May 6, 2025 15:22
@mikoarce mikoarce requested a review from robertroeder May 6, 2025 15:22
@mikoarce mikoarce merged commit 0ef37ef into master May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants