Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the error logging for web push notifications by including the response body in the logs when a failure occurs. It introduces a private helper method, readResponseBody, which uses EntityUtils to extract the response content. The reviewer suggested explicitly specifying UTF-8 encoding when converting the response entity to a string to ensure consistent behavior across different platform environments.
| } | ||
|
|
||
| try { | ||
| return EntityUtils.toString(response.getEntity()); |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련 이슈
✅ 작업 분류
✨ 작업 내용
👥 전달사항
✅ 체크리스트
📸 스크린샷
💡 배운 것 / 시도한 것 / 고민한 점