Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the WebPushSender service to explicitly use AES128GCM encoding when sending notifications. A review comment identifies a potential resource leak where the HttpResponse entity is not consumed on successful requests, which could lead to connection pool exhaustion.
| ); | ||
|
|
||
| HttpResponse response = pushService.send(notification); | ||
| HttpResponse response = pushService.send(notification, Encoding.AES128GCM); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련 이슈
✅ 작업 분류
✨ 작업 내용
👥 전달사항
기존 라이브러리의 동기 send(notification) 기본값이 AESGCM이라서 발생한 것으로 추정.
-> 현대 표준 AES128GCM으로 수정
✅ 체크리스트
📸 스크린샷
💡 배운 것 / 시도한 것 / 고민한 점