-
Notifications
You must be signed in to change notification settings - Fork 1
fix : 약속 상태 자동 전환 및 인증 실패 시 CORS 에러 해결 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -57,6 +57,9 @@ public CandidateRes createCandidate(Long userId, Long promiseId, CandidateCreate | |||||||||
| ); | ||||||||||
| Candidate savedCandidate = candidateRepository.save(candidate); | ||||||||||
|
|
||||||||||
| // 첫 후보지가 등록되면 약속 상태를 진행 중으로 전환 | ||||||||||
| pm.getPromise().proceed(); | ||||||||||
|
|
||||||||||
| return CandidateRes.of(savedCandidate, userId); | ||||||||||
| } | ||||||||||
|
|
||||||||||
|
|
@@ -106,6 +109,11 @@ public void deleteCandidate(Long userId, Long promiseId, Long candidateId) { | |||||||||
| } | ||||||||||
|
|
||||||||||
| candidateRepository.delete(candidate); | ||||||||||
|
|
||||||||||
| // 마지막 후보지 삭제 시 약속 상태를 다시 장소 미정으로 되돌림 | ||||||||||
| if (candidateRepository.countByPromiseId(promiseId) == 0) { | ||||||||||
|
Comment on lines
+113
to
+114
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 비활성화된 후보지가 존재하더라도 활성화된 후보지가 모두 삭제되었다면 약속 상태를 '장소 미정(PENDING)'으로 되돌려야 합니다. 앞서
Suggested change
|
||||||||||
| candidate.getPromise().pend(); | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
| @Override | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
재투표 등으로 인해 비활성화된(inactive) 후보지가 남아있는 경우에도, 활성 후보지가 없다면 약속 상태를 '장소 미정(PENDING)'으로 전환하는 것이 비즈니스 로직상 더 적절합니다. 따라서 단순히 전체 개수를 세는
countByPromiseId대신 활성 상태인 후보지만 카운트하는 메서드를 사용하는 것을 권장합니다.