fix: place Song of Time before removing songs from item pool#164
Closed
ScArWlvrne wants to merge 1 commit into
Closed
fix: place Song of Time before removing songs from item pool#164ScArWlvrne wants to merge 1 commit into
ScArWlvrne wants to merge 1 commit into
Conversation
…e it's put in a location in the category cNoOcarinaStart
Author
|
There's a simpler way to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fill.cpporiginally built the songs vector on line 880 usingFilterAndEraseFromPool(). This led to the Song of Time being removed from the item pool prior to the block beginning on line 883 that was intended to place it in a location within a subset of locations considered reachable during first cycle. This PR moves the building of the songs vector to line 903, after the placing of the Song of Time and Ocarina of Time, immediately before placing other songs, in order to ensure the Song of Time is placed in a valid location.