fix: Song pool logic#165
Merged
Merged
Conversation
…e it's put in a location in the category cNoOcarinaStart
…to ensure it's put in a location in the category cNoOcarinaStart" This reverts commit 82814b5. Reverts an over-complicated bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the logic for placing songs would pull all songs from the main pool before trying to pull Song of Time from the main pool and place it. This PR fixes the fact that Song of Time would never actually be placed in a
cNoOcarinaStartlocation by pulling it from thesongspool instead of the main pool where it no longer exists.