Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix unhandled TypeError for arbitrary IP inputs (DoS)#28

Merged
ManupaKDU merged 1 commit into
mainfrom
sentinel/fix-ipaddress-typeerror-12876541776372777468
Mar 27, 2026
Merged

πŸ›‘οΈ Sentinel: [CRITICAL] Fix unhandled TypeError for arbitrary IP inputs (DoS)#28
ManupaKDU merged 1 commit into
mainfrom
sentinel/fix-ipaddress-typeerror-12876541776372777468

Conversation

@ManupaKDU
Copy link
Copy Markdown
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The is_reachable function passed arbitrary ip inputs to ipaddress.ip_address() while only catching ValueError. However, ipaddress.ip_address() raises TypeError when passed certain invalid types (like None, lists, dictionaries, etc.). This unhandled TypeError could bubble up and crash the ThreadPoolExecutor worker threads, leading to a Denial of Service (DoS) vulnerability.
🎯 Impact: An attacker or a downstream component feeding malformed non-string/int inputs into the scanner could crash the worker threads and potentially the main application aggregator, preventing further network scanning operations.
πŸ”§ Fix: Updated the try...except block around ipaddress.ip_address(ip) to catch TypeError alongside ValueError. Added comprehensive unit tests to ensure different invalid types are gracefully handled and safely logged.
βœ… Verification: Run python3 -m unittest test_testping1.py and observe that test_is_reachable_type_error passes.


PR created automatically by Jules for task 12876541776372777468 started by @ManupaKDU

…ts (DoS)

Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU ManupaKDU merged commit 673d2ab into main Mar 27, 2026
1 check passed
@manupawickramasinghe manupawickramasinghe deleted the sentinel/fix-ipaddress-typeerror-12876541776372777468 branch March 28, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant