Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix Unhandled OverflowError when parsing timeout#39

Closed
ManupaKDU wants to merge 1 commit intomainfrom
sentinel-fix-timeout-overflow-11822385467233456138
Closed

πŸ›‘οΈ Sentinel: [MEDIUM] Fix Unhandled OverflowError when parsing timeout#39
ManupaKDU wants to merge 1 commit intomainfrom
sentinel-fix-timeout-overflow-11822385467233456138

Conversation

@ManupaKDU
Copy link
Copy Markdown
Contributor

🚨 Severity: MEDIUM

πŸ’‘ Vulnerability: Unhandled OverflowError during timeout parsing. The application converted the timeout parameter to an integer using int(). While it handled ValueError and TypeError, passing float('inf') or float('nan') (e.g. from a deserialized JSON payload like {"timeout": Infinity}) would cause an unhandled OverflowError (for inf) or unhandled behavior, which could bubble up and crash worker threads in the ThreadPoolExecutor.

🎯 Impact: Potential Denial of Service (DoS). A malicious user supplying Infinity as a timeout parameter could crash worker threads, reducing the pool's capacity or entirely halting network scans.

πŸ”§ Fix:

  • Updated the try...except block in is_reachable to catch OverflowError alongside ValueError and TypeError.
  • Added unit tests in test_testping1.py specifically for timeout=float('inf') and timeout=float('nan').
  • Recorded the vulnerability and learning in .jules/sentinel.md.

βœ… Verification:

  • Ran the test suite python3 -m unittest test_testping1.py, ensuring the new test cases pass and the unhandled OverflowError no longer occurs.

PR created automatically by Jules for task 11822385467233456138 started by @ManupaKDU

Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe manupawickramasinghe deleted the sentinel-fix-timeout-overflow-11822385467233456138 branch April 8, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants