🎨 Palette: Enhance STOP button with accessible tooltip and description#81
🎨 Palette: Enhance STOP button with accessible tooltip and description#81manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
đź‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a đź‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves accessibility for the Camera fragment’s STOP button by adding a clearer tooltip and screen-reader description.
Changes:
- Added a new string resource (
stop_button_desc) for a more descriptive STOP action label. - Updated
buttonKillinfragment_camera.xmlto includeandroid:contentDescriptionandandroid:tooltipText. - Documented the accessibility learning in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds a new string intended for STOP button accessibility/tooltip text. |
| app/src/main/res/layout/fragment_camera.xml | Applies the new string to STOP button contentDescription and tooltipText. |
| .Jules/palette.md | Records the rationale/pattern for adding accessible tooltips/descriptions to destructive actions. |
đź’ˇ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <!-- Camera Fragment Strings --> | ||
| <string name="app_title">RemoteCam</string> | ||
| <string name="stop_button">STOP</string> | ||
| <string name="stop_button_desc">Stop camera server</string> |
There was a problem hiding this comment.
stop_button_desc is used for the STOP button’s accessibility label/tooltip, but its text (“Stop camera server”) doesn’t reflect the actual user-visible consequence described in stop_confirmation_message (stops the stream and closes the application). This can mislead screen reader/tooltip users; consider aligning this string with the confirmation message (or reusing a shared string) so the tooltip/description matches the real action.
| <string name="stop_button_desc">Stop camera server</string> | |
| <string name="stop_button_desc">Stop camera stream and close application</string> |
| **Action:** Remove overly restrictive `android:textSize` attributes from informational UI elements, allowing them to inherit accessible default text sizes from the application theme. | ||
|
|
||
| ## 2025-10-21 - Accessible Tooltips for Destructive Actions | ||
| **Learning:** Action buttons like "STOP" with brief labels may not convey their full impact (e.g., stopping the stream AND exiting the server) to all users, particularly those relying on screen readers or keyboard navigation. |
There was a problem hiding this comment.
This palette entry describes the STOP action as “stopping the stream AND exiting the server”, but the in-app confirmation text says it will “close the application.” Consider updating the wording here to match the actual behavior to avoid documenting an incorrect outcome.
| **Learning:** Action buttons like "STOP" with brief labels may not convey their full impact (e.g., stopping the stream AND exiting the server) to all users, particularly those relying on screen readers or keyboard navigation. | |
| **Learning:** Action buttons like "STOP" with brief labels may not convey their full impact (e.g., stopping the stream and closing the application) to all users, particularly those relying on screen readers or keyboard navigation. |
đź’ˇ What: Added
contentDescriptionandtooltipTextto thebuttonKill(STOP button) infragment_camera.xml. Also registered a new string resource (stop_button_desc= "Stop camera server") instrings.xml.🎯 Why: The previous "STOP" label was brief and didn't convey the full context of the destructive action (stopping the stream and exiting).
📸 Before/After: N/A (visuals didn't change layout-wise, but hover and screen reader text updated).
♿ Accessibility: Sighted keyboard/mouse users now see a descriptive tooltip, and screen readers will announce a much clearer action context.
PR created automatically by Jules for task 2181017013238381020 started by @manupawickramasinghe