🎨 Palette: [UX improvement] Add context to STOP button#82
🎨 Palette: [UX improvement] Add context to STOP button#82manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
Adds `android:contentDescription` and `android:tooltipText` to the `buttonKill` in `fragment_camera.xml` to improve screen reader and hover context. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves accessibility/UX of the Camera Fragment’s STOP button by adding a descriptive label for screen readers and a tooltip for hover/long-press, without changing visual UI.
Changes:
- Added a new string resource describing the STOP action (“Stop camera server”).
- Wired the STOP button to use that string for
android:contentDescriptionandandroid:tooltipText. - Documented the accessibility learning/action in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds a new string resource used for STOP button accessibility/tooltip text. |
| app/src/main/res/layout/fragment_camera.xml | Applies the new content description and tooltip to the STOP button. |
| .Jules/palette.md | Records the accessibility improvement practice for destructive actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <!-- Camera Fragment Strings --> | ||
| <string name="app_title">RemoteCam</string> | ||
| <string name="stop_button">STOP</string> | ||
| <string name="stop_button_desc">Stop camera server</string> |
There was a problem hiding this comment.
The new accessibility label/tooltip "Stop camera server" doesn’t fully match what this action does elsewhere: pressing STOP leads to a confirmation that says it will stop the stream and close the application, and the click handler finishes the activity. Consider updating this string (or using a dedicated string) to reflect the full consequence (e.g., stopping streaming and closing the app) so screen reader/tooltip text is accurate.
| <string name="stop_button_desc">Stop camera server</string> | |
| <string name="stop_button_desc">Stop camera stream and close application</string> |
💡 What: Added
contentDescriptionandtooltipTextattributes to the "STOP" button.🎯 Why: The button previously only displayed "STOP". For screen reader users or users hovering with a mouse/keyboard, "Stop camera server" provides crucial context about the destructive action that will occur.
📸 Before/After: No visual changes.
♿ Accessibility: TalkBack will now announce "Stop camera server" instead of just "STOP", and a tooltip appears on hover/long-press.
PR created automatically by Jules for task 12979350014065754225 started by @manupawickramasinghe