🎨 Palette: Add descriptive labels to STOP button#83
🎨 Palette: Add descriptive labels to STOP button#83manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility and discoverability in the camera UI by adding a descriptive label for the “STOP” action so screen readers and tooltips convey the full intent (“Stop camera server”) without changing the visual UI.
Changes:
- Added a new localized string (
stop_button_desc) describing the STOP action. - Applied
android:contentDescriptionandandroid:tooltipTextto the STOP button infragment_camera.xml. - Documented the accessibility guideline in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds a new string resource used for accessibility/tooltip text on the STOP button. |
| app/src/main/res/layout/fragment_camera.xml | Sets content description and tooltip text for the STOP button to provide better context. |
| .Jules/palette.md | Records the accessibility learning/action for brief or destructive UI actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
💡 What: Added
android:contentDescriptionandandroid:tooltipTextto the "STOP" button in the camera fragment.🎯 Why: The visual label "STOP" is brief and may lack context. This provides a full explanation ("Stop camera server") for screen reader users and those hovering with a mouse/keyboard.
📸 Before/After: The button visually appears identical, but now has informative hover text and screen reader spoken context.
♿ Accessibility: Improves TalkBack experience by reading out the action's true outcome, and aids sighted users navigating via alternative inputs with a helpful tooltip.
PR created automatically by Jules for task 8738874861720185800 started by @manupawickramasinghe