chore: gate/remove hot-path debug logs (R2–R6 from #31)#233
Open
MrCoder wants to merge 3 commits into
Open
Conversation
…Full) and paid-client rationale for Full being last
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safe, no-behavior-change removal of diagnostic
console.logcalls identified in the Forge usage audit (issue #31, R2–R6). No control flow, return values, error handling, or load-bearing telemetry is touched.Changes
functions/utils/authenticate.ts(R2)console.log('ALLOWED_FORGE_APP_IDS:', ...)(line 45) andconsole.log('validateContextToken - payload', ...)(line 48)functions/_middleware.ts(R3)console.log('Function request url:', ...)functions/utils/dbUtils.ts(R4)console.logDB-result dumps; dropped unusedconst result =assignments that only existed to feed those logsfunctions/utils/R2Bucket.ts(R5)Writing to ${key}andenv.EVENT_BUCKET:)functions/forge-installed.ts(R6)console.log('forge-installed body:', data)What is NOT changed
macro_viewed,duration_ms, paywall events,macro_export_*telemetry — untouchedconsole.errorandconsole.warncalls — kept (load-bearing diagnostics)Test plan
pnpm test:unit— 638 tests, all passingpnpm lint— 0 errors (functions/ is excluded from project ESLint by existing config)