Skip to content

fix(banner): position restore-draft banner below app header#243

Draft
MrCoder wants to merge 1 commit into
mainfrom
agent/peng-s-claude-dev/98d0202f
Draft

fix(banner): position restore-draft banner below app header#243
MrCoder wants to merge 1 commit into
mainfrom
agent/peng-s-claude-dev/98d0202f

Conversation

@MrCoder

@MrCoder MrCoder commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The draft-restoration banner was rendered with position:fixed; top:0, placing it over the app header which contains the diagram title input and Publish button
  • Fixed by querying the app header element (header.header) for its actual bottom position via getBoundingClientRect(), falling back to 56px (the h-14 header height) when the element isn't found yet
  • Affects all editor variants (sequence, mermaid, openapi, graph, embed) since the banner is shared via restoreDraftBanner.ts

Test plan

  • All 665 unit tests pass
  • Spot check on staging: open editor, make unsaved change, close, reopen — banner should appear below the header, not over the title/Publish button

Co-authored-by: multica-agent <github@multica.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant