fix(e2e): re-ground staging-gate specs for editor-as-landing#822
Merged
Conversation
…are / boots the editor (not the hub); gotoHome → /?view=diagrams; smoke asserts editor@/ + hub@?view=diagrams; persistence restore rides the last-code slot (bare / carries no ?id); 9/9 local
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
rewrite/web-foundationmerge (#821) brought editor-as-landing to master: bare/now boots the editor (resume last-code / sample), and the hub moved to/?view=diagrams. The roote2e/tests/staging-gate specs were still hub-adapted (/= HomeView), so the staging E2E gate failed on 5 tests (smoke,library×3,persistence) — which correctly blocked the prod release (no draft was cut).What
Re-ground the root specs for editor-as-landing (single-source helper + the 3 specs). App code untouched —
e2e/only.helpers/hub.js—gotoHome()→/?view=diagrams(+HUB_URLconst);openEditor()already handled the editor surface so bare/now no-ops the click-through.smoke.spec.js— the/-is-hub test now asserts/boots the editor (dsl-editorvisible,home-viewabsent) and/?view=diagramsrenders the hub.library.spec.js— flows through the fixedgotoHome/reloadIntoLibrary; all list/filter/export/import assertions unchanged.persistence.spec.js— bare/carries no?id(save doesn't navigate), so reload restore rides the last-codelocalStorage['code']slot (the boot path editor-as-landing actually takes). Removed only the obsolete?idURL guards; the type→save→reload→UNIQUE_PARTICIPANT-restored assertion is preserved.Validation
npx playwright test e2e/tests/{smoke,library,persistence}.spec.js --project=chromium→ 9 passed, 0 failed locally (deterministic across runs). No app/web/code changed.