Skip to content

core: fix minor bugs across arm_semihosting, EchoExample, mmio #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
by965738071 wants to merge 1 commit into from
+5 −5
Closed

core: fix minor bugs across arm_semihosting, EchoExample, mmio #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/core/arm_semihosting.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ pub const fs = struct {
};

pub const FType = enum {
FIle,
File,
Device,
};
pub const OpenMode = enum(usize) {
Expand Down Expand Up @@ -390,7 +390,7 @@ pub const fs = struct {

pub fn get_type(file: File) FileError!FType {
return switch (sys_istty(&file)) {
0 => FType.FIle,
0 => FType.File,
1 => FType.Device,
else => FileError.InvalidFile,
};
Expand Down
2 changes: 1 addition & 1 deletion core/src/core/usb/drivers/EchoExample.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pub fn init(self: *@This(), desc: *const Descriptor, device: *usb.DeviceInterfac
.device = device,
.descriptor = desc,
.packet_buffer = data,
.tx_ready = .init(false),
.tx_ready = .init(true),
};
device.ep_listen(
desc.ep_out.endpoint.num,
Expand Down
4 changes: 2 additions & 2 deletions core/src/mmio.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ pub fn Mmio(comptime Packed: type) type {
@as(FieldType, @enumFromInt(@as(U, @intFromEnum(@field(val, field_name))) ^
@as(U, @intFromEnum(@as(FieldType, value)))));
},
else => |T| {
@compileError("unsupported register field type '" ++ @typeName(T) ++ "'");
else => {
@compileError("unsupported register field type '" ++ @typeName(FieldType) ++ "'");
},
}
}
Expand Down
Loading