Skip to content

fix(webview): sync cachedState on mode changes in SettingsView #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
easonLiangWorldedtech wants to merge 2 commits into
base: main
Choose a base branch
from
+300 −35
Open

fix(webview): sync cachedState on mode changes in SettingsView #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8d7ce
fix(webview): sync cachedState on mode changes in SettingsView
easonliang28 Jul 17, 2026
188b53c
test(settings): strengthen mode sync change detection
easonliang28 Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions webview-ui/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
const { t } = useAppTranslation()

const extensionState = useExtensionState()
const { currentApiConfigName, listApiConfigMeta, uriScheme, settingsImportedAt } = extensionState
const { currentApiConfigName, listApiConfigMeta, uriScheme, settingsImportedAt, mode } = extensionState

const [isDiscardDialogShow, setDiscardDialogShow] = useState(false)
const [isChangeDetected, setChangeDetected] = useState(false)
Expand All @@ -147,6 +147,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
const contentRef = useRef<HTMLDivElement | null>(null)

const prevApiConfigName = useRef(currentApiConfigName)
const prevMode = useRef(mode)
const handledSettingsImportedAt = useRef<number | undefined>(undefined)
const confirmDialogHandler = useRef<() => void>()

Expand Down Expand Up @@ -220,16 +221,17 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
const apiConfiguration = useMemo(() => cachedState.apiConfiguration ?? {}, [cachedState.apiConfiguration])

useEffect(() => {
// Update only when currentApiConfigName is changed.
// Expected to be triggered by loadApiConfiguration/upsertApiConfiguration.
if (prevApiConfigName.current === currentApiConfigName) {
// Update when currentApiConfigName or mode changes.
// Expected to be triggered by loadApiConfiguration/upsertApiConfiguration or mode switch.
if (prevApiConfigName.current === currentApiConfigName && prevMode.current === mode) {
return
}

setCachedState((prevCachedState) => ({ ...prevCachedState, ...extensionState }))
prevApiConfigName.current = currentApiConfigName
prevMode.current = mode
setChangeDetected(false)
}, [currentApiConfigName, extensionState])
}, [currentApiConfigName, mode, extensionState])

// Bust the cache when settings are imported.
useEffect(() => {
Expand Down
Loading
Loading