Skip to content

fix(mcp): remove obsolete server creation translations#943

Open
WebMad wants to merge 3 commits into
Zoo-Code-Org:mainfrom
WebMad:fix/895-mcp-server-creation-setting
Open

fix(mcp): remove obsolete server creation translations#943
WebMad wants to merge 3 commits into
Zoo-Code-Org:mainfrom
WebMad:fix/895-mcp-server-creation-setting

Conversation

@WebMad

@WebMad WebMad commented Jul 18, 2026

Copy link
Copy Markdown

Summary

  • remove the unused enableServerCreation localization block
  • clean up the obsolete setting text across all supported webview locales
  • keep the historical changelog entry intact

Validation

  • parsed all modified MCP locale JSON files
  • ran node scripts/find-missing-translations.js
  • ran git diff --check

Related docs update will be submitted separately to Zoo-Code-Org/Zoo-Code-Docs.

Closes #895

Summary by CodeRabbit

  • Localization
    • Updated MCP settings translations across supported languages.
    • Removed the MCP server-creation label, description, and hint, and aligned the UI copy to focus on enabling connected MCP server tools.
    • Adjusted toggle messaging in select locales to better reflect the enable/disable behavior (including cost guidance where applicable).
  • Tests
    • Updated the “no servers” MCP-hub prompt snapshot to match the latest generated output.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • src/core/prompts/__tests__/__snapshots__/add-custom-instructions/no-mcp-servers.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea90b561-1a65-4b2e-932f-2658af1073f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The MCP locale files remove obsolete enableServerCreation translation blocks. Hindi, Indonesian, Vietnamese, and Simplified Chinese update enableToggle wording to describe enabling tools from connected MCP servers. The MCP no-server prompt test now uses a full snapshot assertion.

Changes

MCP localization and prompt validation

Layer / File(s) Summary
Remove obsolete MCP server creation strings
webview-ui/src/i18n/locales/*/mcp.json
Removes the enableServerCreation title, description, and hint across locales; selected locales update enableToggle text for connected MCP server tool usage.
Update no-server prompt coverage
src/core/prompts/__tests__/add-custom-instructions.spec.ts
Replaces the prior absence check and snapshot with a full no-mcp-servers.snap assertion for an MCP hub without servers.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: edelauna

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing obsolete MCP server creation translations.
Description check ✅ Passed The description includes the summary, validation steps, linked issue, and notes the separate docs follow-up.
Linked Issues check ✅ Passed The locale cleanup removes the stale enableServerCreation text the issue calls out, and the separate docs follow-up is acknowledged.
Out of Scope Changes check ✅ Passed All changes are limited to MCP locale cleanup and the matching test update, with no unrelated scope introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Docs mention missing Enable MCP Server Creation setting

1 participant