feat: add DataPart.fromJson() factory method for raw JSON strings#778
Open
jmesnil wants to merge 1 commit intoa2aproject:mainfrom
Open
feat: add DataPart.fromJson() factory method for raw JSON strings#778jmesnil wants to merge 1 commit intoa2aproject:mainfrom
jmesnil wants to merge 1 commit intoa2aproject:mainfrom
Conversation
Allow developers to create a DataPart directly from a JSON string without manually deserializing it into Java objects first. This fixes a2aproject#753 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces fromJson factory methods to the DataPart class, enabling the creation of instances from JSON strings using Gson. It also adds a comprehensive test suite in DataPartTest.java. A review comment identifies a potential Denial of Service vulnerability due to the lack of input size limits and suggests an explicit check for the JSON 'null' literal to ensure the implementation matches the provided Javadoc.
Collaborator
|
@jmesnil Should it also provides OffsetDateTimeTypeAdapter ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow developers to create a DataPart directly from a JSON string without manually deserializing it into Java objects first.
This fixes #753