Follow-up refactors [breaking changes]#8
Open
robuye wants to merge 1 commit into
Open
Conversation
* move code in Store to AWSConfig * rename Profile to ConfigEntry * cleanup Parser code * cleanup ProfileResolver More details: The code in Store was used only in AWSConfig file. This added unnecessary indirection, since AWSConfig is an entry point for the gem it's natural to have the code live in the file. Profile has been renamed to ConfigEntry. It's representation of a config. It is associated with a profile (accessed via AWSConfig), but it isn't always representing a complete configuration. The class is used to encapsulate nested properties too. ProfileResolver always refreshes all sourced profiles. It makes the code easier, but also avoids potential edge cases when a duplicate profile is added, it's being merged and it should be re-sourced. This it very unlikely to ever happen, but we don't need to worry about it since we always re-source all profiles when anything is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details:
The code in Store was used only in AWSConfig file. This added
unnecessary indirection, since AWSConfig is an entry point for
the gem it's natural to have the code live in the file.
Profile has been renamed to ConfigEntry. It's representation of a
config. It is associated with a profile (accessed via AWSConfig),
but it isn't always representing a complete configuration. The class
is used to encapsulate nested properties too.
ProfileResolver always refreshes all sourced profiles. It makes the
code easier, but also avoids potential edge cases when a duplicate
profile is added, it's being merged and it should be re-sourced. This
it very unlikely to ever happen, but we don't need to worry about it
since we always re-source all profiles when anything is added.