refactor: Decouple and deprecate core locale, plumb via catalog factory#1610
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors locale configuration by moving it from the surface/context level to the catalog level. It introduces factory functions (such as createBasicCatalogFunctions) to allow instantiating catalog functions with a specific locale, while deprecating the legacy locale properties on DataContext and SurfaceModel. Feedback on these changes highlights that the subclass BasicCatalog in Angular has a parameterless constructor, which prevents configuring the locale when it is injected via Angular DI. It is recommended to update BasicCatalog to accept options via an InjectionToken to support proper dependency injection configuration.
|
LGTM. Should we add a line in the changelog for this change? |
Good idea. There was an existing entry mentioning the previous API, so I updated it to reflect the current one. |
Description
This Pull Request decouples the
localeparameter from core models (SurfaceModelandDataContext) and plumbs it directly via a localized basic catalog function factory inside@a2ui/web_core/v0_9/basic_catalog.By deprecating the legacy, core-level parameters and providing a localized factory (
createBasicCatalogFunctions), we:BASIC_FUNCTIONS).@a2ui/angular's options).Fixes #1609
Pre-launch Checklist