Skip to content

Revert "build(deps): update yarn packages and resolve build, test, an…#1643

Closed
ditman wants to merge 1 commit into
a2ui-project:mainfrom
ditman:web-downgrade-vite
Closed

Revert "build(deps): update yarn packages and resolve build, test, an…#1643
ditman wants to merge 1 commit into
a2ui-project:mainfrom
ditman:web-downgrade-vite

Conversation

@ditman

@ditman ditman commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Revert "build(deps): update yarn packages and resolve build, test, and lint deprecations (#1616)"

This reverts commit 85381fc.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades numerous dependencies across the repository's renderers, samples, and tools, including reverting React to v18 and Angular CDK/Material to v20. Key feedback on these changes addresses a critical version mismatch between Angular core and Material packages, and warns that lowering the bundle budget limits in angular.json will likely trigger production build failures. Additionally, reviewers recommend keeping test assertions inside the waitFor block to prevent flakiness, retaining ESLint disable comments in layout.tsx to avoid Next.js custom font linting errors, and removing redundant tslib declarations from devDependencies.

Comment thread samples/client/angular/package.json
Comment thread samples/client/angular/angular.json
Comment thread renderers/react/tests/v0_8/integration/components.test.tsx
Comment thread tools/composer/src/app/layout.tsx
Comment thread renderers/angular/package.json
Comment thread samples/client/angular/package.json
@ditman ditman marked this pull request as ready for review June 13, 2026 01:41
@ditman

ditman commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

Well, this won't run until conflicts are resolved and I won't do that right now.

@ditman ditman closed this Jun 13, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant