Skip to content

feat: Add websockets#692

Merged
aXenDeveloper merged 2 commits into
canaryfrom
ws
Jun 1, 2026
Merged

feat: Add websockets#692
aXenDeveloper merged 2 commits into
canaryfrom
ws

Conversation

@aXenDeveloper
Copy link
Copy Markdown
Owner

Improving Documentation

Description

What?

Why?

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vitnode-docs Ready Ready Preview, Comment Jun 1, 2026 8:56pm

@github-actions github-actions Bot added the 💡 Feature A new feature label Jun 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a multiplexed WebSocket system to VitNode, enabling real-time features like channels, cross-tab connection sharing via Web Locks and BroadcastChannel, and a built-in notification system with admin controls. However, several critical issues were identified in the review: Hono's WSContext lacks a readyState property, which silently breaks server-to-client messaging; accessing the browser-only WebSocket global during SSR in provider.tsx will crash server-side rendering; potential TypeError crashes exist when destructuring the session user and accessing c.get("core"); and unhandled promise rejections from asynchronous message handlers should be caught to prevent process crashes.

Comment thread packages/vitnode/src/ws/registry.ts Outdated
Comment thread packages/vitnode/src/ws/provider.tsx
Comment thread packages/vitnode/src/views/layouts/theme/layout.tsx Outdated
Comment thread packages/vitnode/src/ws/handle.ts Outdated
Comment thread packages/vitnode/src/ws/handle.ts Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b5e838361

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/vitnode/src/ws/provider.tsx Outdated
Comment thread packages/vitnode/src/ws/provider.tsx
@aXenDeveloper aXenDeveloper merged commit 6c7a349 into canary Jun 1, 2026
4 checks passed
@aXenDeveloper aXenDeveloper deleted the ws branch June 1, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 Feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant