feat: Add websockets#692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a multiplexed WebSocket system to VitNode, enabling real-time features like channels, cross-tab connection sharing via Web Locks and BroadcastChannel, and a built-in notification system with admin controls. However, several critical issues were identified in the review: Hono's WSContext lacks a readyState property, which silently breaks server-to-client messaging; accessing the browser-only WebSocket global during SSR in provider.tsx will crash server-side rendering; potential TypeError crashes exist when destructuring the session user and accessing c.get("core"); and unhandled promise rejections from asynchronous message handlers should be caught to prevent process crashes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b5e838361
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?