Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76905c84dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| notifyText: 'Aave V4 is now live on Ethereum mainnet.', | ||
| buttonText: 'Try it out here', |
There was a problem hiding this comment.
Changing notifyText/buttonText without changing bannerVersion means users who previously dismissed the old waitlist banner will continue to have warningBarOpen_<chainId>=false and won’t see this new announcement. In TopBarNotify, the banner only reopens when storedBannerVersion !== currentCampaign.bannerVersion, so this copy update will be hidden for a large existing cohort unless the version key is incremented.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Updates the main layout’s top notification banner copy to promote the Aave V4 launch, across all configured chain IDs.
Changes:
- Replaces the existing banner
notifyTextandbuttonTextstrings for multiple networks inMainLayout. - Keeps the existing banner action (URL) and versioning as-is.
Comments suppressed due to low confidence (1)
src/layouts/MainLayout.tsx:22
- The banner dismissal logic is keyed by
bannerVersion(stored in localStorage). Since the copy changed butbannerVersionremainsaave-app-waitlist-v2, users who previously dismissed the old banner may never see this new message. BumpbannerVersionto a new value aligned with the V4 launch banner so it re-shows as intended.
notifyText: 'Aave V4 is now live on Ethereum mainnet.',
buttonText: 'Try it out here',
buttonAction: {
type: 'url' as const,
value: 'https://aave.com/app',
target: '_blank' as const,
},
bannerVersion: 'aave-app-waitlist-v2',
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| notifyText: 'Aave V4 is now live on Ethereum mainnet.', | ||
| buttonText: 'Try it out here', |
There was a problem hiding this comment.
These are user-facing strings, but they’re plain string literals in a config object. Because TopBarNotify wraps notifyText/buttonText in <Trans>{…}</Trans> with dynamic children, Lingui won’t extract these messages for translation, so they will remain English-only. Please convert the banner copy to Lingui macros (e.g., t/Trans with literal children) and adjust TopBarNotify accordingly so extraction works.
| notifyText: 'Aave V4 is now live on Ethereum mainnet.', | ||
| buttonText: 'Try it out here', |
There was a problem hiding this comment.
PR description appears to be the default template (“Fixes XYZ bug”, “Adds XYZ feature”, etc.) and doesn’t describe the actual change (banner copy update). Please update the PR description/checklist items to reflect the real intent and any relevant validation performed.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files