Skip to content

Sort vulnerabilities from newest to oldest in API responses #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashwinraj8090 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Sort vulnerabilities from newest to oldest in API responses #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vulnerabilities/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ class VulnerabilityViewSet(viewsets.ReadOnlyModelViewSet):
Lookup for vulnerabilities affecting packages.
"""

queryset = Vulnerability.objects.all()
queryset = Vulnerability.objects.all().order_by('-vulnerability_id')

def get_fixed_packages_qs(self):
"""
Expand Down Expand Up @@ -703,7 +703,7 @@ class CPEViewSet(VulnerabilityViewSet):

queryset = Vulnerability.objects.filter(
vulnerabilityreference__reference_id__startswith="cpe"
).distinct()
).distinct().order_by('-vulnerability_id')

filterset_class = CPEFilterSet

Expand All @@ -723,7 +723,7 @@ def bulk_search(self, request):
return Response(status=400, data={"Error": f"Invalid CPE: {cpe}"})
vulnerabilitiesResponse = Vulnerability.objects.filter(
vulnerabilityreference__reference_id__in=cpes
).distinct()
).distinct().order_by('-vulnerability_id')
return Response(
VulnerabilitySerializer(
vulnerabilitiesResponse, many=True, context={"request": request}
Expand Down
8 changes: 4 additions & 4 deletions vulnerabilities/api_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ class VulnerabilityViewSet(viewsets.ReadOnlyModelViewSet):
Lookup for vulnerabilities by id.
"""

queryset = Vulnerability.objects.all()
queryset = Vulnerability.objects.all().order_by('-vulnerability_id')
serializer_class = V2VulnerabilitySerializer
lookup_field = "vulnerability_id"
filter_backends = (filters.DjangoFilterBackend,)
Expand Down Expand Up @@ -377,7 +377,7 @@ class CPEViewSet(viewsets.ReadOnlyModelViewSet):

queryset = Vulnerability.objects.filter(
vulnerabilityreference__reference_id__startswith="cpe"
).distinct()
).distinct().order_by('-vulnerability_id')
serializer_class = V2VulnerabilitySerializer
filter_backends = (filters.DjangoFilterBackend,)
throttle_classes = [PermissionBasedUserRateThrottle]
Expand All @@ -397,7 +397,7 @@ def bulk_search(self, request):
for cpe in cpes:
if not cpe.startswith("cpe"):
return Response(status=400, data={"Error": f"Invalid CPE: {cpe}"})
qs = Vulnerability.objects.filter(vulnerabilityreference__reference_id__in=cpes).distinct()
qs = Vulnerability.objects.filter(vulnerabilityreference__reference_id__in=cpes).distinct().order_by('-vulnerability_id')
return Response(V2VulnerabilitySerializer(qs, many=True, context={"request": request}).data)


Expand All @@ -415,7 +415,7 @@ class AliasViewSet(viewsets.ReadOnlyModelViewSet):
(https://nvd.nist.gov/general/cve-process).
"""

queryset = Vulnerability.objects.all()
queryset = Vulnerability.objects.all().order_by('-vulnerability_id')
serializer_class = V2VulnerabilitySerializer
filter_backends = (filters.DjangoFilterBackend,)
filterset_class = AliasFilterSet
Expand Down
4 changes: 2 additions & 2 deletions vulnerabilities/api_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def get_url(self, obj):
)
)
class VulnerabilityV2ViewSet(viewsets.ReadOnlyModelViewSet):
queryset = Vulnerability.objects.all()
queryset = Vulnerability.objects.all().order_by('-vulnerability_id')
serializer_class = VulnerabilityV2Serializer
lookup_field = "vulnerability_id"
throttle_classes = [AnonRateThrottle, PermissionBasedUserRateThrottle]
Expand Down Expand Up @@ -487,7 +487,7 @@ class PackageV2ViewSet(viewsets.ReadOnlyModelViewSet):
queryset = Package.objects.all().prefetch_related(
Prefetch(
"affected_by_vulnerabilities",
queryset=Vulnerability.objects.prefetch_related("fixed_by_packages"),
queryset=Vulnerability.objects.prefetch_related("fixed_by_packages").order_by("-vulnerability_id"),
to_attr="prefetched_affected_vulnerabilities",
)
)
Expand Down