Update "ThemedSection" component to responsively reduce vertical padding on smaller screens#534
Merged
brian-montgomery merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
…ing sizes for smaller screens. Achieve this by applying the pattern established by the existing "ColumnedHero" component. Remove existing optional padding class from "ThemedSection" component to unify the look across the website.
✅ Deploy Preview for accessiblecommunity ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brian-montgomery
approved these changes
Apr 14, 2026
Contributor
brian-montgomery
left a comment
brian-montgomery
left a comment
There was a problem hiding this comment.
I forgot that bootstrap had those specific sized classes... good job using them.
Just noting that verticalPadding is fairly long to type and, with it being a string array, you don't use it anywhere. Just a note that you want to make things easy to use from the client perspective.
Contributor
Author
|
@brian-montgomery thank you for the feedback. I have now changed the name of the property from "verticalPaddings" to "yPaddings" to shorten it. I was thinking this specific property would not be modified when the component is used, as it would help to maintain a more uniform look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the responsive sizing pattern established by the existing "ColumnedHero" component that @brian-montgomery had already created. Remove existing optional padding class from "ThemedSection" component to unify the look across the website.
Fixes #531