Add formatHolderCount helper for compact holder display.#465
Merged
Chucks1093 merged 1 commit intoJun 26, 2026
Merged
Conversation
Closes accesslayerorg#438 by formatting counts under 1K as plain strings and larger values with one-decimal K/M suffixes, with unit tests for each range and boundary values. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Yormee-103 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This batch covers four contributor and UX improvements across docs, formatting, empty states, and test coverage:
Closes #439 — Added a Shared utility helpers section to CONTRIBUTING.md documenting address shortening, URL/handle/price formatting helpers with input/output examples, and a note to add new formatting logic in src/utils/ instead of inline in components.
Closes #441 — Added integration tests for Change24hBadge direction indicators (up/down/none for positive, negative, and zero change) and fixed zero-change behavior so it no longer shows the minus icon.
Closes #440 — Added EmptyCreatorList for zero-result creator searches with a readable message and Clear search button; wired it into LandingPage with component and landing-page tests.
Closes #438 — Added formatHolderCount() in numberFormat.utils.ts for compact holder counts (999, 1.2K, 2.4M) with unit tests for each range and boundary values at 1,000 and 1,000,000.
Test plan
Testing
pnpm lintpnpm buildChecklist