test: add integration test for ledgerToTimestamp (#461)#467
Merged
Chucks1093 merged 1 commit intoJun 26, 2026
Merged
Conversation
|
@Kaycee276 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #461
This PR adds an integration test for the
ledgerToTimestamphelper to confirm its timestamp estimation accuracy using known, hardcoded reference values. This ensures the conversion logic is fully verified before the helper is adopted in the production UI.The integration test explicitly verifies the helper against a known reference point (Ledger
50,000,000at2024-01-01T00:00:00.000Z) to satisfy all acceptance criteria:Changes
src/utils/__tests__/stellarLedger.integration.test.tsto cleanly separate the integration test with hardcoded data from the standard unit tests.Verification
pnpm test src/utils/__tests__/stellarLedger.integration.test.ts. All 3 tests pass successfully.