feat(creator-keys): add transfer entrypoint and enforce unique holder…#436
Open
N-thnI wants to merge 2 commits into
Open
feat(creator-keys): add transfer entrypoint and enforce unique holder…#436N-thnI wants to merge 2 commits into
N-thnI wants to merge 2 commits into
Conversation
… count state invariants
|
@N-thnI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… count state invariants
Summary
Description
This PR implements a direct key transfer entrypoint (
transfer_key) to the contract surface and ensures that uniqueholder_countmetrics adjust accurately based on pre- and post-transfer balances.Scope of Changes
transfer_keyfunction utilizing existing balance and dividend-settlement checkpoints.holder_countwhen a sender transfers their entire remaining balance.holder_countwhen a recipient acquires keys for the first time.holder_countunchanged on partial transfers where the sender retains assets.Verification Checklist
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
creator-keysunit/integration tests for every changed contract behavior, including failure paths for new or reachableContractErrorvariantscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspace, or explained exactly why a command was not rundocs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility notedocs/contract-event-conventions.md, or documented the breaking change and versioning plancloses #422