feat: add tests for issues #471, #472, #475, #477#493
Merged
Chucks1093 merged 2 commits intoJun 27, 2026
Conversation
…cesslayerorg#475, accesslayerorg#477 accesslayerorg#477 — Add field-level tests for ProtocolFeeRecipientUpdated event - New protocol_fee_recipient_updated_event.rs with three tests asserting old_recipient field, new_recipient field, and exactly-one-event-per-call accesslayerorg#475 — Change get_buyback_quote to return 0 for amount=0; add tests - get_buyback_quote now short-circuits with Ok(0) when amount is zero instead of returning NotPositiveAmount (view functions should not reject zero-valued reads) - buyback itself keeps its validate_buyback_amount guard unchanged - Updated test_buyback_zero_amount_reverts to cover only the operation path - New get_buyback_quote_zero_amount.rs with three tests: returns zero, does not change supply, does not change holder balance accesslayerorg#471 — Add setup_holders fixture helper and confirmation tests - New setup_holders helper in contract_test_env/mod.rs: registers N wallets with varied key balances in one call and returns final total supply - New setup_holders_helper.rs with two confirmation tests accesslayerorg#472 — Add regression tests for locked allocation bonding-curve supply - New locked_allocation_bonding_curve_supply.rs with three tests: supply equals locked amount immediately, buy quote reflects that supply via the bonding curve, creator without allocation starts at zero supply
|
@privexlabs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Reformats protocol_fee_recipient_updated_event.rs, get_buyback_quote_zero_amount.rs, locked_allocation_bonding_curve_supply.rs, and setup_holders_helper.rs to match the project's rustfmt configuration.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four test-coverage issues across the creator-keys contract.
tests
Changes
buyback operation continues to reject zero amounts
quote view)
Test plan
Closes #477
Closes #475
Closes #471
Closes #472