feat: resolve multiple backend issues#479
Open
anoncon wants to merge 1 commit into
Open
Conversation
- Add structured performance log to wallet activity feed query (fixes accesslayerorg#460) - Add integration test for creator holders endpoint 404 case (fixes accesslayerorg#458) - Add shared paginateQuery helper for cursor-based database navigation (fixes accesslayerorg#459) - Document integration test patterns and DB seeding in CONTRIBUTING.md (fixes accesslayerorg#462)
|
@anoncon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves multiple outstanding backend issues in a single batch to streamline our endpoints and developer experience.
Changes Included
GET /wallets/:address/activityendpoint. Includes result count, query duration, masked wallet address, and active filters.creator-holders-404.test.ts) ensuring that requesting holders for a non-existent creator returns a clear 404 response body, rather than an empty list.paginateQueryutility inpagination.utils.tsto standardize queries across the app, complete with full unit tests.CONTRIBUTING.mddemonstrating integration test structure, database seeding, a minimal worked example, and local test runner commands.Closes #460
Closes #458
Closes #459
Closes #462
Verification
paginateQueryunit tests covering first page, subsequent page, and final page scenarios.