Skip to content

feat: implement issues #485, #486, #487, #488#500

Open
emmanueltony792-blip wants to merge 1 commit into
accesslayerorg:mainfrom
emmanueltony792-blip:feature/issues-485-486-487-488
Open

feat: implement issues #485, #486, #487, #488#500
emmanueltony792-blip wants to merge 1 commit into
accesslayerorg:mainfrom
emmanueltony792-blip:feature/issues-485-486-487-488

Conversation

@emmanueltony792-blip

Copy link
Copy Markdown
Contributor

#485: Add serializeBigInt helper for safe BigInt serialization in JSON

  • Export serializeBigInt() as a named alias over sanitizeBigInts()
  • Rewrite unit tests with Jest describe blocks covering all acceptance criteria

#486: Add structured debug log for price snapshot write

  • Add ledgerSequence field to TradeEventPayload
  • Emit debug log with creator_id, new_price, previous_price, ledger_sequence, written_at on every successful snapshot write (initial and update paths)
  • Error log on failure was already present

#487: Enforce webhook max registration limit with 422

  • Change service error from 409 to 422 for MAX_WEBHOOKS_REACHED
  • Update existing integration test assertion to expect 422
  • Add dedicated integration test file for the limit enforcement scenario

#488: Document ownership read model schema

  • Add docs/indexer/ownership-read-model.md with table schema, update triggers, balance conservation invariant, and replay consistency behavior

Summary

Testing

  • pnpm lint
  • pnpm build
  • pnpm exec prisma generate when schema or generated types changed

Checklist

…layerorg#487, accesslayerorg#488

accesslayerorg#485: Add serializeBigInt helper for safe BigInt serialization in JSON
- Export serializeBigInt() as a named alias over sanitizeBigInts()
- Rewrite unit tests with Jest describe blocks covering all acceptance criteria

accesslayerorg#486: Add structured debug log for price snapshot write
- Add ledgerSequence field to TradeEventPayload
- Emit debug log with creator_id, new_price, previous_price, ledger_sequence,
  written_at on every successful snapshot write (initial and update paths)
- Error log on failure was already present

accesslayerorg#487: Enforce webhook max registration limit with 422
- Change service error from 409 to 422 for MAX_WEBHOOKS_REACHED
- Update existing integration test assertion to expect 422
- Add dedicated integration test file for the limit enforcement scenario

accesslayerorg#488: Document ownership read model schema
- Add docs/indexer/ownership-read-model.md with table schema, update triggers,
  balance conservation invariant, and replay consistency behavior
@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@emmanueltony792-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment