feat: implement issues #485, #486, #487, #488#500
Open
emmanueltony792-blip wants to merge 1 commit into
Open
Conversation
…layerorg#487, accesslayerorg#488 accesslayerorg#485: Add serializeBigInt helper for safe BigInt serialization in JSON - Export serializeBigInt() as a named alias over sanitizeBigInts() - Rewrite unit tests with Jest describe blocks covering all acceptance criteria accesslayerorg#486: Add structured debug log for price snapshot write - Add ledgerSequence field to TradeEventPayload - Emit debug log with creator_id, new_price, previous_price, ledger_sequence, written_at on every successful snapshot write (initial and update paths) - Error log on failure was already present accesslayerorg#487: Enforce webhook max registration limit with 422 - Change service error from 409 to 422 for MAX_WEBHOOKS_REACHED - Update existing integration test assertion to expect 422 - Add dedicated integration test file for the limit enforcement scenario accesslayerorg#488: Document ownership read model schema - Add docs/indexer/ownership-read-model.md with table schema, update triggers, balance conservation invariant, and replay consistency behavior
|
@emmanueltony792-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#485: Add serializeBigInt helper for safe BigInt serialization in JSON
#486: Add structured debug log for price snapshot write
#487: Enforce webhook max registration limit with 422
#488: Document ownership read model schema
Summary
Testing
pnpm lintpnpm buildpnpm exec prisma generatewhen schema or generated types changedChecklist