feat: resolve issues #485 #486 #487 #488#534
Merged
Chucks1093 merged 1 commit intoJun 27, 2026
Merged
Conversation
…rorg#487 accesslayerorg#488 accesslayerorg#485: add serializeBigInt alias for sanitizeBigInts and wire into response serializer (sendSuccess, sendPaginatedSuccess); expand unit tests to cover all four acceptance criteria accesslayerorg#486: emit structured debug log after each successful price snapshot write with creator_id, new_price, previous_price, ledger_sequence, written_at; skip log when price unchanged; error log on failure was already present accesslayerorg#487: change webhook max-limit error from 422 (was 409); update integration test to assert 422 status, descriptive error message, and that webhook count stays at the limit after the failed attempt accesslayerorg#488: add docs/architecture/ownership-read-model.md documenting KeyOwnership table schema, buy/sell/transfer update triggers, balance conservation invariant, and replay consistency behaviour chore: add package-lock.json to .gitignore; remove trailing artifact
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#485: add serializeBigInt alias for sanitizeBigInts and wire into response serializer (sendSuccess, sendPaginatedSuccess); expand unit tests to cover all four acceptance criteria
#486: emit structured debug log after each successful price snapshot write with creator_id, new_price, previous_price, ledger_sequence, written_at; skip log when price unchanged; error log on failure was already present
#487: change webhook max-limit error from 422 (was 409); update integration test to assert 422 status, descriptive error message, and that webhook count stays at the limit after the failed attempt
#488: add docs/architecture/ownership-read-model.md documenting KeyOwnership table schema, buy/sell/transfer update triggers, balance conservation invariant, and replay consistency behaviour
chore: add package-lock.json to .gitignore; remove trailing artifact
Summary
Testing
pnpm lintpnpm buildpnpm exec prisma generatewhen schema or generated types changedChecklist
closes Add helper for safely serializing BigInt values in JSON API responses #485
closes Add structured log for price snapshot write with creator ID and new price after each trade #486
closes Add integration test for creator webhook max registration limit being enforced #487
closes Add docs for ownership read model schema and how it is kept in sync with the indexer #488