Move the QRZ.COM credentials settings to the Integrations Page#985
Open
alanhargreaves wants to merge 2 commits into
Open
Move the QRZ.COM credentials settings to the Integrations Page#985alanhargreaves wants to merge 2 commits into
alanhargreaves wants to merge 2 commits into
Conversation
Contributor
verified
verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In spite of a clear notice that this is a setting only for folks running local servers people are still asking about how to set it.
This PR moves it to the Integrations settings panel and have it part of the Local-only settings and have it only settable if isLocalInstall is true.
Type of change
How to test
a. Verify the QRZ.COM Credentials settings do not appear on the Profiles Settings panel
b. Verify the QRZ.COM Credentials settings appear on the integrations page, the fields can be filled in and on completion of both text fields, the button becomes enabled.
a. Verify the QRZ.COM Credentials settings do not appear on the Profiles Settings panel
b. Verify that the QRZ.COm credentials settings cannot be edited
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included