feat(ui-react)!: update PageHeader to match current Figma anatomy#554
Merged
Conversation
madjorr
force-pushed
the
feature/page-header
branch
from
July 20, 2026 14:01
1c6a781 to
94a7c40
Compare
Add PageHeaderTags and PageHeaderDescriptionRow, restyle the title to the design's 24px/regular style, and remove PageHeaderBreadcrumb — the breadcrumb is now a separate sibling above PageHeader in the design, not one of its parts. Re-map Code Connect to the real master component (node 2905-7678) and refresh the ui-spec, tests, stories, and VR baselines to match. BREAKING CHANGE: PageHeaderBreadcrumb is removed. Render a Breadcrumb above PageHeader instead of nesting one inside it.
Implements the two hard requirements from the Figma "Breakpoints" page that were previously unimplemented: PageHeaderTags collapses to the first tag plus a "+#" tag (tooltip lists the hidden labels) when the full set doesn't fit, and PageHeaderActions folds secondary buttons under a single "More" ButtonIcon menu, leaving primary buttons always visible. Both are all-or-nothing collapses per the Figma wording, not a partial "however many fit" reflow. Also fixes PageHeaderDescriptionRow to use items-start instead of items-center, so the edit pencil sits flush with the first line of a wrapped description instead of floating mid-paragraph, matching Figma.
…" menu Folding reconstructs a secondary action as a "Menu Item" with a single click action — a trigger component like ButtonMenu opens its own menu instead, so it has nothing to reduce to and silently became inert when folded. isSecondaryAction now also requires item.type === Button; non- Button actions stay visible and unfolded even with variant="secondary". Updates the two stories that misused ButtonMenu this way, the ui-spec behavior scenario, and regenerates the affected VR baseline.
madjorr
force-pushed
the
feature/page-header
branch
from
July 21, 2026 07:00
94a7c40 to
ae49633
Compare
…into "More" menu
A folded Button used render to become a link (e.g. render={<a href=...>}) lost
that behavior once collapsed — DropdownMenuItem only picked disabled/onClick/
children. Also regenerate the stale dark-mode VR baseline for
WithTagsAndActions.
…ions into "More" menu Folding reconstructed the menu item from only disabled/onClick/render/children, dropping aria-label and other native attributes — breaking accessible names for icon-only secondary actions once they overflow into the "More" menu.
marta-sampedro
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PageHeaderTags and PageHeaderDescriptionRow, restyle the title to the design's 24px/regular style, and remove PageHeaderBreadcrumb — the breadcrumb is now a separate sibling above PageHeader in the design, not one of its parts. Re-map Code Connect to the real master component (node 2905-7678) and refresh the ui-spec, tests, stories, and VR baselines to match.
BREAKING CHANGE: PageHeaderBreadcrumb is removed. Render a Breadcrumb above PageHeader instead of nesting one inside it.
Type of change
Description
Related issue
📸 Screenshots (if appropriate)
Checklist