feat: Counterfactual v5 beacon updates#1490
Conversation
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 109b20c0c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gateway = config.gateway; | ||
| spokePoolDepositExecutor = config.spokePoolDepositExecutor; | ||
| cctpDepositExecutor = config.cctpDepositExecutor; | ||
| oftDepositExecutor = config.oftDepositExecutor; |
There was a problem hiding this comment.
When the canonical deploy/upgrade path calls DeployCounterfactualBeacon, CounterfactualConfig._buildChainConfig() still only assigns fields up to wethSpokePoolMaxExecutionFee, so these newly added members stay at Solidity zero defaults. These assignments therefore bake gateway and all source executor getters as address(0) for every scripted deployment/upgrade, making any V5 Gateway-routed counterfactual leaf that resolves them unconfigured until another UUPS upgrade is performed.
Useful? React with 👍 / 👎.
tbwebb22
force-pushed
the
taylor/counterfactuals-v5-beacon-updates
branch
from
087f423 to
6517f11
Compare
1 participant
No description provided.