chore: Use Paxos API for Pending Withdrawals#3535
Conversation
dijanin-brat
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 746f4e30c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert(l2Token.toNative() === this.l2TokenAddress, `Unsupported L2 token ${l2Token.toNative()}`); | ||
|
|
||
| try { | ||
| const orders = await listOutstandingPaxosTransitOrders(this.client, fromAddress.toNative()); |
There was a problem hiding this comment.
For Robinhood/Paxos withdrawals, this API path ignores the l2EventConfig block range that AdapterManager.getL2PendingWithdrawalAmountWithLookbackPeriod builds from the configured withdrawExcessPeriod. If an order remains PENDING_BRIDGE/PROCESSING after that period, it will still be counted against InventoryClient's "last N seconds" withdrawal-volume cap, whereas the previous transfer-event query only counted initiations inside the lookback window; that can keep excess withdrawals blocked long after the configured period has elapsed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
i would say that we want that so we can see if there are withdrawals that are stuck
1 participant
No description provided.