feat: Create SameAssetRebalancer#3561
Merged
Merged
Conversation
- Extend InventoryClient withdrawExcessBalances() and rebalanceInventoryIfNeeded() to allow caller to retrieve the set of potential rebalances (based on the configured inventory config) without executing any rebalances through the InventoryClient - Creates a SameAssetRebalancerClient that (1) asks the InventoryClient for the set of rebalances + withdrawals and (2) executes them using the `swap-rebalancer/`'s adapters - Creates a setup script that hardcodes USDT rebalances through Binance between Ethereum and Avalanche - Adds a new bot parallel to the `swapRebalancer` that can be run independently from the swap rebalancer called the `sameAssetRebalancer`
nicholaspai
changed the title
nicholaspai
requested review from
bmzig,
dijanin-brat,
mrice32 and
pxrl
as code owners
| (route.sourceChain === this.config.hubPoolChainId && route.destinationChain !== this.config.hubPoolChainId) || | ||
| (route.sourceChain !== this.config.hubPoolChainId && route.destinationChain === this.config.hubPoolChainId) | ||
| ) | ||
| ) { |
Contributor
There was a problem hiding this comment.
Maybe its more readable to do something like
if ((srcChain === hubPool && dstChain === hubPool) || (srcChain !== hubPool && dstChain !== hubPool))
It will discard the outer negation. Tho its nothing major so i am okey with leaving it like this 👍
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 517bbd5345
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swap-rebalancer/'s adaptersswapRebalancerthat can be run independently from the swap rebalancer called thesameAssetRebalancer